Closed sbryzak closed 5 years ago
Thank you @sbryzak for this contribution!
It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests
as a comment to make the status green.
Your plugin configuration is stored in the file.
Merging #819 into master will increase coverage by
0.08%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 78.42% 78.51% +0.08%
==========================================
Files 98 98
Lines 9168 9158 -10
==========================================
Hits 7190 7190
+ Misses 1445 1438 -7
+ Partials 533 530 -3
Impacted Files | Coverage Δ | |
---|---|---|
authentication/account/service/user.go | 76.84% <ø> (+0.79%) |
:arrow_up: |
configuration/configuration.go | 83.44% <100%> (-0.12%) |
:arrow_down: |
...rovider/service/authentication_provider_service.go | 72.22% <0%> (-1.12%) |
:arrow_down: |
...ication/account/worker/user_deactivation_worker.go | 83.87% <0%> (+22.58%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2836b06...88668ab. Read the comment docs.
There is another PR which does the revert - https://github.com/fabric8-services/fabric8-auth/pull/823 I think we can close this one.
Reverts fabric8-services/fabric8-auth#818