search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

refactor worker interval config #822

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

return values in seconds rather than minutes

Fixes #ODC589

Signed-off-by: Xavier Coulon xcoulon@redhat.com

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @xcoulon for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #822 into master will not change coverage. The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #822   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          98       98           
  Lines        9168     9168           
=======================================
  Hits         7190     7190           
  Misses       1445     1445           
  Partials      533      533
Impacted Files Coverage Δ
configuration/configuration.go 83.56% <33.33%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2836b06...de27a3e. Read the comment docs.

xcoulon commented 5 years ago

thanks for spotting the remaining time.Minute , @alexeykazakov 🙌

alexeykazakov commented 5 years ago

/ok-without-tests

xcoulon commented 5 years ago

thanks for the review, @alexeykazakov