search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Enable user deactivation #823

Closed alexeykazakov closed 5 years ago

alexeykazakov commented 5 years ago
  1. Reverts the test mode introduced by https://github.com/fabric8-services/fabric8-auth/pull/818 (with some fixes)
  2. Enables notifications & deactivation workers
  3. Sets worker cycles to one hour instead of 4 minutes.
alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @alexeykazakov for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #823 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
+ Coverage   78.42%   78.51%   +0.08%     
==========================================
  Files          98       98              
  Lines        9168     9158      -10     
==========================================
  Hits         7190     7190              
+ Misses       1445     1438       -7     
+ Partials      533      530       -3
Impacted Files Coverage Δ
authentication/account/service/user.go 76.84% <ø> (+0.79%) :arrow_up:
...ication/account/worker/user_deactivation_worker.go 83.87% <100%> (+22.58%) :arrow_up:
configuration/configuration.go 83.44% <100%> (-0.12%) :arrow_down:
...rovider/service/authentication_provider_service.go 72.22% <0%> (-1.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e04bc6d...ec96b85. Read the comment docs.

xcoulon commented 5 years ago

/ok-without-tests