search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

refactor deactivation worker locking #830

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

attempt to obtain a lock at each cycle, but only release during shutdown

fixes #ODC625

Signed-off-by: Xavier Coulon xcoulon@redhat.com

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @xcoulon for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #830 into master will increase coverage by 0.01%. The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #830      +/-   ##
=========================================
+ Coverage   78.49%   78.5%   +0.01%     
=========================================
  Files          98      98              
  Lines        9168    9175       +7     
=========================================
+ Hits         7196    7203       +7     
  Misses       1442    1442              
  Partials      530     530
Impacted Files Coverage Δ
worker/worker.go 81.53% <55.55%> (+2.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00ff3eb...6267dcf. Read the comment docs.

alexeykazakov commented 5 years ago

/ok-without-tests

xcoulon commented 5 years ago

LGTM. Just wondering if we could add some tests for that...

yeah, we already have some tests, but it seems like there was no need to change anything in the test despite the change in the lock obtention strategy...