search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Fix delete users in WIT #834

Closed alexeykazakov closed 5 years ago

alexeykazakov commented 5 years ago

We should use username, not ID when calling WIT. This error is not critical. It's just logged and ignored but still worth fixing.

Also, I've changed the order of deactivation. Delete from WIT, Che, Tenant first. If Che fails then return an error. If Tenant fails then return an error. If both Che and Tenant succeed then proceed with removing the user from Auth DB.

codecov[bot] commented 5 years ago

Codecov Report

Merging #834 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
+ Coverage      78%   78.03%   +0.02%     
==========================================
  Files          98       98              
  Lines        9254     9295      +41     
==========================================
+ Hits         7219     7253      +34     
- Misses       1497     1502       +5     
- Partials      538      540       +2
Impacted Files Coverage Δ
authentication/account/service/user.go 76.28% <100%> (+1.28%) :arrow_up:
wit/service/wit_service.go 92% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f527bd...b2e0a4e. Read the comment docs.