search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

record metrics for deactivations #835

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

fixes #ODC622

Signed-off-by: Xavier Coulon xcoulon@redhat.com

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @xcoulon for this contribution!

It seems that this PR already contains some added or changed tests. Good job!

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #835 into master will decrease coverage by 0.04%. The diff coverage is 70.58%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #835      +/-   ##
========================================
- Coverage   78.04%    78%   -0.05%     
========================================
  Files          98     99       +1     
  Lines        9283   9334      +51     
========================================
+ Hits         7245   7281      +36     
- Misses       1500   1513      +13     
- Partials      538    540       +2
Impacted Files Coverage Δ
authentication/account/service/user.go 74.41% <100%> (+0.6%) :arrow_up:
metric/metric.go 67.39% <67.39%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 344b7da...510dd49. Read the comment docs.

xcoulon commented 5 years ago

thanks for the review @MatousJobanek ! @alexeykazakov I've added a test for the /metrics endpoint, similar to what @MatousJobanek did in tenant service: https://github.com/fabric8-services/fabric8-auth/pull/835/commits/510dd494cf800854266fb6334cce4d1d70fbb1e4