search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Don't fail deactivation if user not found #836

Closed alexeykazakov closed 5 years ago

alexeykazakov commented 5 years ago

Follow up on https://github.com/fabric8-services/fabric8-auth/pull/834#discussion_r280301696

User could be deactivated/deleted partially. For example in Che we succeed but failed in Tenant. In this case reg app will reschedule deactivation. So, we want to ignore not found errors in the flow (just log them) otherwise re-deactivation won't ever succeed.

codecov[bot] commented 5 years ago

Codecov Report

Merging #836 into master will increase coverage by 0.02%. The diff coverage is 93.93%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #836      +/-   ##
========================================
+ Coverage   77.98%    78%   +0.02%     
========================================
  Files          98     98              
  Lines        9253   9272      +19     
========================================
+ Hits         7216   7233      +17     
- Misses       1499   1500       +1     
- Partials      538    539       +1
Impacted Files Coverage Δ
che/service/che_service.go 75.6% <100%> (+5.91%) :arrow_up:
authentication/account/service/tenant.go 87.09% <100%> (+1.91%) :arrow_up:
controller/namedusers.go 96.49% <71.42%> (-3.51%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3ab16b...611f09a. Read the comment docs.

alexeykazakov commented 5 years ago

[test]

alexeykazakov commented 5 years ago

Thanks for the review!

nurali-techie commented 5 years ago

@alexeykazakov I thought it is service_consumer code_link which decided to ignore not found rather service_proivder code_link.