search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Remove worker pool from user deactivation notification worker #843

Closed sbryzak closed 5 years ago

sbryzak commented 5 years ago

Fixes https://jira.coreos.com/browse/ODC-754

This pull request simply removes the worker pool from the NotifyIdentitiesBeforeDeactivation() function and instead invokes the notification action synchronously.

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @sbryzak for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

xcoulon commented 5 years ago

/ok-without-tests

codecov[bot] commented 5 years ago

Codecov Report

Merging #843 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   78.01%   78.09%   +0.08%     
==========================================
  Files          99       99              
  Lines        9341     9318      -23     
==========================================
- Hits         7287     7277      -10     
+ Misses       1511     1502       -9     
+ Partials      543      539       -4
Impacted Files Coverage Δ
authentication/account/service/user.go 78.12% <100%> (+3.7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f2bc87...01cf824. Read the comment docs.