search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

assert db clean result #846

Closed nurali-techie closed 5 years ago

nurali-techie commented 5 years ago

enable assert when doing db_clean during tear_down in tests.

codecov[bot] commented 5 years ago

Codecov Report

Merging #846 into master will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
- Coverage   78.08%   78.06%   -0.02%     
==========================================
  Files          99       99              
  Lines        9317     9318       +1     
==========================================
- Hits         7275     7274       -1     
- Misses       1503     1505       +2     
  Partials      539      539
Impacted Files Coverage Δ
configuration/configuration.go 81.69% <0%> (-0.46%) :arrow_down:
migration/migration.go 67.24% <0%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10b94c7...1c73a51. Read the comment docs.

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @nurali-techie for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

nurali-techie commented 5 years ago

There are Three integration test which started failing when assert is enabled.

  1. Test - TestRunResourceServiceBlackBoxTest/TestDeleteResourceWithCycleReferencesFails Error - pq: update or delete on table "resource" violates foreign key constraint "resource_parent_resource_id_fkey" on table "resource"

  2. Test - TestRunResourceTypeBlackBoxTest/TestCreateResourceTypeWithDefaultRoleID Error - pq: update or delete on table "role" violates foreign key constraint "resource_type_default_role_id_fkey" on table "resource_type"

  3. Test - TestRunSpaceServiceBlackBoxTest/TestCreateOK Error - pq: update or delete on table "resource" violates foreign key constraint "identity_role_resource_id_fkey" on table "identity_role"

xcoulon commented 5 years ago

/ok-without-tests