search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Remove _total from counter metric names to avoid conversion to Hz #847

Closed alexeykazakov closed 5 years ago

alexeykazakov commented 5 years ago

Counter type metrics (as inferred from names like _total) are automatically rate-converted to Hz by pcp.

If we rename the counter metrics away from *_total then the row counter should be available in pcp.

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @alexeykazakov for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #847 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #847   +/-   ##
=======================================
  Coverage   78.08%   78.08%           
=======================================
  Files          99       99           
  Lines        9327     9327           
=======================================
  Hits         7283     7283           
  Misses       1505     1505           
  Partials      539      539
Impacted Files Coverage Δ
metric/metric.go 69.56% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b38ee9b...f294329. Read the comment docs.

sbose78 commented 5 years ago

/ok-without-tests