search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

log when deactivation counter metric is incremented #848

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

Log when the deactivation counter is incremented, just like we do for the deactivation notification counter

Signed-off-by: Xavier Coulon xcoulon@redhat.com

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @xcoulon for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #848 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   78.08%   78.09%   +<.01%     
==========================================
  Files          99       99              
  Lines        9327     9331       +4     
==========================================
+ Hits         7283     7287       +4     
  Misses       1505     1505              
  Partials      539      539
Impacted Files Coverage Δ
metric/metric.go 72% <100%> (+2.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82b17f9...fdcd749. Read the comment docs.

alexeykazakov commented 5 years ago

/ok-without-tests