search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

change level of message when deactivation fails in WIT #850

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

Change level to WARN as we just log the error that occurred on WIT anyways.

Signed-off-by: Xavier Coulon xcoulon@redhat.com

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @xcoulon for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #850 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #850   +/-   ##
=====================================
  Coverage      78%    78%           
=====================================
  Files          99     99           
  Lines        9354   9354           
=====================================
  Hits         7297   7297           
  Misses       1515   1515           
  Partials      542    542
Impacted Files Coverage Δ
authentication/account/service/user.go 78.01% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3470e2b...bbcacb3. Read the comment docs.

alexeykazakov commented 5 years ago

/ok-without-tests