fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

Clean up che when banning users #853

Closed alexeykazakov closed 5 years ago

alexeykazakov commented 5 years ago

When we ban users we should also clean up che workspaces.

TODO:

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @alexeykazakov for this contribution!

It seems that this PR already contains some added or changed tests. Good job!

Your plugin configuration is stored in the file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #853 into master will decrease coverage by 0.02%. The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
- Coverage   78.11%   78.08%   -0.03%     
==========================================
  Files          99       99              
  Lines        9360     9361       +1     
==========================================
- Hits         7312     7310       -2     
- Misses       1510     1514       +4     
+ Partials      538      537       -1
Impacted Files Coverage Δ
controller/namedusers.go 95.83% <100%> (-0.66%) :arrow_down:
authentication/account/service/user.go 79.79% <81.25%> (+1.07%) :arrow_up:
controller/users.go 76.18% <0%> (-0.53%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dfdfbf1...51f1156. Read the comment docs.