search

fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

filter users to deactivate by IDP #854

Closed xcoulon closed 5 years ago

xcoulon commented 5 years ago

Filter users to notify and deactivate by IDP, since this is what we also do when performing the deactivation (and banning)

Also, change a log message to match the same usual pattern: error while ..., which makes searching in the logs more consistent.

Signed-off-by: Xavier Coulon xcoulon@redhat.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #854 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
+ Coverage   78.11%   78.11%   +<.01%     
==========================================
  Files          99       99              
  Lines        9359     9360       +1     
==========================================
+ Hits         7311     7312       +1     
  Misses       1510     1510              
  Partials      538      538
Impacted Files Coverage Δ
controller/namedusers.go 96.49% <100%> (ø) :arrow_up:
authentication/account/repository/identity.go 76.7% <100%> (ø) :arrow_up:
migration/migration.go 67.42% <100%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 004b0eb...7d851ee. Read the comment docs.