fabric8-services / fabric8-auth

Identity and Access Management for fabric8 services
https://auth.openshift.io/api/status
Apache License 2.0
14 stars 26 forks source link

remove usage of request in generate token methods #861

Closed nurali-techie closed 5 years ago

nurali-techie commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #861 into master will increase coverage by 0.06%. The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
+ Coverage    77.9%   77.96%   +0.06%     
==========================================
  Files         100      100              
  Lines        9824     9817       -7     
==========================================
+ Hits         7653     7654       +1     
+ Misses       1600     1596       -4     
+ Partials      571      567       -4
Impacted Files Coverage Δ
authorization/token/manager/token_manager.go 83.35% <100%> (+1.45%) :arrow_up:
configuration/configuration.go 81.9% <100%> (ø) :arrow_up:
rest/rest.go 83.33% <57.14%> (-6.33%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98b5bbc...04d9181. Read the comment docs.

nurali-techie commented 5 years ago

@xcoulon thanks for review :-)