search

fabric8-services / fabric8-jenkins-idler

OpenShift.io service to idle resp.unidle Jenkins instances
Apache License 2.0
4 stars 15 forks source link

Add dry run mode mode #220

Closed concaf closed 5 years ago

concaf commented 6 years ago

This commit lets configuring the idler to not do any actual idling but instead perform a dry run where the state of the cluster is not changed by introducing an environment variable JC_DRY_RUN, which is set to true will run idler in a test mode without really idling.

Fixes #213

centos-ci commented 6 years ago

Can one of the admins verify this patch?

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @containscafeine for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.

concaf commented 6 years ago

@chmouel @sthaha I've used dry run instead of test mode, let me know if you'd want to change that. Also, could you help me test this, since I'm unable to get UUIDs locally using the curl command mentioned in the startup script.

chmouel commented 6 years ago

Tests and humm a test 👎

hrishin commented 5 years ago

closed it as its addressed in idler refactoring story.