search

fabric8-services / fabric8-jenkins-idler

OpenShift.io service to idle resp.unidle Jenkins instances
Apache License 2.0
4 stars 15 forks source link

Improves log messages #326

Closed hrishin closed 5 years ago

hrishin commented 5 years ago

Idling/Unidling error message is ambigious. Also its hard to trace what info tenant service returns to idler

This patch improves log message which says idling or unidling failed. Also adds log message to debug what info tenant service returns in response.

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @hrishin for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

hrishin commented 5 years ago

/ok-without-tests

alien-ike commented 5 years ago

Hey @hrishin! It seems you tried to trigger /ok-without-tests command, but this will not have any effect due to insufficient permission. You have to be admin or requested reviewer or pull request approver, but not pull request creator for this command to take an effect.

piyush-garg commented 5 years ago

/ok-without-tests