search

fabric8-services / fabric8-jenkins-idler

OpenShift.io service to idle resp.unidle Jenkins instances
Apache License 2.0
4 stars 15 forks source link

Idle users by default when toggle service is unreachable #332

Closed sthaha closed 5 years ago

sthaha commented 5 years ago

When connection to feature toggle service is broken, the unleash_toggle returned that the Idler is disabled for the user. This resulted in idler not idling certain users. This patch changes the fallback so that by default all users are idled unless explicitly disabled by feature toggle service (f8toggles) and the service is reachable.

Fixes: #333

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @sthaha for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.