Closed lordofthejars closed 6 years ago
@nurali-techie If you can review it :)
I don't know much about prometheus but i trust you on this has been tested and working, 👍 after the rebase,
sorry @lordofthejars for reviewing your PR late. Actually I was involved in multiple prometheus PR and I overlook yours. I have provided few review comments. Functionally, your code looks good :-) There are few design things which you can do. Ping me anytime if you want more details on how to in-corporate my design review comments.
Can one of the admins verify this patch?