Issue #231 Add Prometheus metrics for accessing type counter

fabric8-services / fabric8-jenkins-proxy

Apache License 2.0

1 stars 16 forks source link

Issue #231 Add Prometheus metrics for accessing type counter #232

Closed lordofthejars closed 6 years ago

centos-ci commented 6 years ago

Can one of the admins verify this patch?

lordofthejars commented 6 years ago

@nurali-techie If you can review it :)

chmouel commented 6 years ago

I don't know much about prometheus but i trust you on this has been tested and working, 👍 after the rebase,

nurali-techie commented 6 years ago

sorry @lordofthejars for reviewing your PR late. Actually I was involved in multiple prometheus PR and I overlook yours. I have provided few review comments. Functionally, your code looks good :-) There are few design things which you can do. Ping me anytime if you want more details on how to in-corporate my design review comments.