fabric8-services / fabric8-jenkins-proxy

Apache License 2.0
1 stars 16 forks source link

[WIP] Issue #165 Too many redirects #235

Closed kishansagathiya closed 6 years ago

kishansagathiya commented 6 years ago

Fixes #165

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @kishansagathiya for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.

kishansagathiya commented 6 years ago

Build is failing because of https://github.com/golang/lint/issues/397

kishansagathiya commented 6 years ago

When the it redirects to jenkins it redirects to https://jenkins-ksagathi-preview-jenkins.b542.starter-us-east-2a.openshiftapps.com/. Who makes sure that the URL shows https://jenkins.openshift.io instead?

kishansagathiya commented 6 years ago

And when it redirects, it creates a link called found instead of directly redirecting. I have to click on Found to go to Jenkins. Right now, I don't know why I see this Found link (Didnt find any code which could do so), will have to investigate more on that. screenshot from 2018-04-25 12-21-05 screenshot from 2018-04-25 12-43-26

kishansagathiya commented 6 years ago

https://www.reddit.com/r/golang/comments/3loqtq/how_to_redirect_a_user_after_login/