search

fabric8-services / fabric8-jenkins-proxy

Apache License 2.0
1 stars 16 forks source link

Issue #239 Adds retry operation for getUser call #240

Closed lordofthejars closed 6 years ago

lordofthejars commented 6 years ago

This commit adds a retry to getUser operation because it has been detected some sync issues between jenkins-proxy and wit.

The issue was originally opened at https://github.com/openshiftio/openshift.io/issues/3252

centos-ci commented 6 years ago

Can one of the admins verify this patch?

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @lordofthejars for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.

lordofthejars commented 6 years ago

The problem is not fake time at all, the problem is that getUser is not tested probably because you need wit

chmouel commented 6 years ago

i let the others reviewing it,

lordofthejars commented 6 years ago

@sthaha I think that with the latest commit I have fixed any problem with err variable, although it was more a cosmetic problem rather than a compilation problem.