fabric8-services / fabric8-jenkins-proxy

Apache License 2.0
1 stars 16 forks source link

Issue #243 Show if Cluster Capacity is Reached #248

Closed kishansagathiya closed 6 years ago

kishansagathiya commented 6 years ago

Idler would be giving 503 if Cluster Tenant Resource Capacity is Reached. Modified Unidle function to handle that

Now waiting template will show the message "Cluster Tenant resource capacity for current cluster is full, please wait...", if Cluster Capacity is reached

243

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @kishansagathiya for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.

kishansagathiya commented 6 years ago

@sthaha @containscafeine What would be really nice for this is some UI magic such that the message that we see while jenkins is unidling changes dynamically i.e., If the ajax request that the page sent to proxy gives 503 change the message to Cluster Tenant resource capacity for current cluster is full, please wait... and if it gives 202 it should change to Jenkins has been idled. It is starting now, please wait...

WDYT?

sthaha commented 6 years ago

/ok-without-tests

concaf commented 6 years ago

Nice work @kishansagathiya