search

fabric8-services / fabric8-jenkins-proxy

Apache License 2.0
1 stars 16 forks source link

Issue #249 Make Redirection to Auth Temporary #250

Closed kishansagathiya closed 6 years ago

kishansagathiya commented 6 years ago

Right now redirection to Auth for login is permanent (301). Since permanent redirects are prolematic and might create a link instead of directly redirecting. This should be changed to temporary redirection(307), which is what this commit does.

Fixes #249

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @kishansagathiya for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.

alien-ike commented 6 years ago

Hey @kishansagathiya! It seems you tried to trigger /ok-without-tests command, but this will not have any effect due to insufficient permission. You have to be admin or requested reviewer or pull request approver, but not pull request creator for this command to take an effect.

sthaha commented 6 years ago

/ok-without-tests