Closed sthaha closed 6 years ago
Can one of the admins verify this patch?
Thank you @sthaha for this contribution!
It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests
as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin - for example exclude certain file types so if PR contains only them it won't be checked.
/ok-without-tests
Hey @sthaha! It seems you tried to trigger /ok-without-tests
command, but this will not have any effect due to insufficient permission. You have to be admin or requested reviewer or pull request approver, but not pull request creator for this command to take an effect.
/ok-without-tests
Hey @sthaha! It seems you tried to trigger /ok-without-tests
command, but this will not have any effect due to insufficient permission. You have to be admin or requested reviewer or pull request approver, but not pull request creator for this command to take an effect.
/ok-without-tests
Proxy uses
!idler.IsIdle()
to check if pods are running but that is wrong as IsIdle can returnfalse
if pods are juststarting
orterminating
. Hence lets use the new api in idler status to check if the Pods are actually running.