Closed sthaha closed 6 years ago
Thank you @sthaha for this contribution!
It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests
as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.
/ok-without-tests
Previous attempt do enable CORS didn't have AllowHeaders = "*" set so passing in 'Authorization' header which was required for
start
api resulted in the following error:This has been fixed by adding
AllowedHeaders: []string{"*"},
Additionally, the patch also allows all standard CRUD methods and enables Debug logs for
cors
ifconfig.GetDebugMode()
is set