Fix #309 Refactored the cors test

[hrishin]

• if the test fails its easy to identify which case is failing
• avoids DRY(dont repeat yourself) and makes it more readable

Fixes #309

[centos-ci]

Can one of the admins verify this patch?

[kishansagathiya]

@hrishin Travis build is failing This is due to our commit message rules Use this format

Issue #NUMBER Start with capital, Title<50 chars

Leave a line. Wrap it with 72 chars in a line

[hrishin]

@sthaha @kishansagathiya could you review it, please?

[hrishin]

@sthaha local environment it's running well.

go test github.com/fabric8-services/fabric8-jenkins-proxy/cmd/fabric8-jenkins-proxy github.com/fabric8-services/fabric8-jenkins-proxy/cmd/osio github.com/fabric8-services/fabric8-jenkins-proxy/cmd/osio/cmd github.com/fabric8-services/fabric8-jenkins-proxy/internal/api github.com/fabric8-services/fabric8-jenkins-proxy/internal/clients github.com/fabric8-services/fabric8-jenkins-proxy/internal/configuration github.com/fabric8-services/fabric8-jenkins-proxy/internal/jenkinsapi github.com/fabric8-services/fabric8-jenkins-proxy/internal/metric github.com/fabric8-services/fabric8-jenkins-proxy/internal/proxy github.com/fabric8-services/fabric8-jenkins-proxy/internal/proxy/reverseproxy github.com/fabric8-services/fabric8-jenkins-proxy/internal/router github.com/fabric8-services/fabric8-jenkins-proxy/internal/storage github.com/fabric8-services/fabric8-jenkins-proxy/internal/testutils github.com/fabric8-services/fabric8-jenkins-proxy/internal/testutils/mock github.com/fabric8-services/fabric8-jenkins-proxy/internal/util github.com/fabric8-services/fabric8-jenkins-proxy/internal/util/logging github.com/fabric8-services/fabric8-jenkins-proxy/internal/version
ok      github.com/fabric8-services/fabric8-jenkins-proxy/cmd/fabric8-jenkins-proxy     11.819s
?       github.com/fabric8-services/fabric8-jenkins-proxy/cmd/osio      [no test files]
?       github.com/fabric8-services/fabric8-jenkins-proxy/cmd/osio/cmd  [no test files]
?       github.com/fabric8-services/fabric8-jenkins-proxy/internal/api  [no test files]
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/clients      0.013s
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/configuration        0.008s
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/jenkinsapi   0.006s
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/metric       0.013s
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/proxy        0.016s
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/proxy/reverseproxy   0.026s
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/router       0.025s
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/storage      7.769s
?       github.com/fabric8-services/fabric8-jenkins-proxy/internal/testutils    [no test files]
?       github.com/fabric8-services/fabric8-jenkins-proxy/internal/testutils/mock       [no test files]
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/util 0.015s
ok      github.com/fabric8-services/fabric8-jenkins-proxy/internal/util/logging 0.009s
?       github.com/fabric8-services/fabric8-jenkins-proxy/internal/version      [no test files]

Its missing something?

[kishansagathiya]

@hrishin Go through travis logs. Your formatting seems wrong. It fails when it runs make fmtcheck. Try this command in your branch, you might get more info on why it is failing.

[hrishin]

thanks, @kishansagathiya. fixed now.