fabric8-services / fabric8-jenkins-proxy

Apache License 2.0
1 stars 16 forks source link

`make vendor` doesn't seem to add new dependencies #317

Closed kishansagathiya closed 6 years ago

kishansagathiya commented 6 years ago

This is what happened to me today

[kishansagathiya@localhost fabric8-jenkins-proxy]$ make all
go install -ldflags="-X github.com/fabric8-services/fabric8-jenkins-proxy/internal/version.version=1369edf" ./cmd/fabric8-jenkins-proxy
internal/auth/auth.go:16:2: cannot find package "github.com/matryer/resync" in any of:
    /home/kishansagathiya/go/fabric8/src/github.com/fabric8-services/fabric8-jenkins-proxy/vendor/github.com/matryer/resync (vendor tree)
    /usr/local/go/src/github.com/matryer/resync (from $GOROOT)
    /home/kishansagathiya/go/fabric8/src/github.com/matryer/resync (from $GOPATH)
make: *** [Makefile:41: build] Error 1
[kishansagathiya@localhost fabric8-jenkins-proxy]$ make vendor
make: 'vendor' is up to date.
[kishansagathiya@localhost fabric8-jenkins-proxy]$ 

dep ensure -v would get us out of this problem, but then we shouldn't have to run it. It is added in make vendor

chmouel commented 6 years ago

make clean;make vendor;