fabric8-services / fabric8-jenkins-proxy

Apache License 2.0
1 stars 16 forks source link

Proxy fails to invalidate old cookies when environment is reset #321

Closed sthaha closed 5 years ago

sthaha commented 6 years ago

Steps:

Expected:

Actual:

This happens because the internal cache does not reflect the fact that jenkins was reset and the old jessionid won't work anymore.

kishansagathiya commented 6 years ago

If we consider only reset environment case, we can fix this by clearing cache on reset env. On not finding cookie in cache, proxy would expire the cookie and ask for relogin.

But a more generic solution could be

@sthaha @chmouel

kishansagathiya commented 6 years ago

Same situation cannot happen with jenkinsIdled cookie as we check status of Jenkins pod even if we have the cookie