Remove content repository

fabric8-services / fabric8-tenant-jenkins

Generates Jenkins tenant namespace YAML

Apache License 2.0

2 stars 14 forks source link

Remove content repository #108

Closed kishansagathiya closed 6 years ago

kishansagathiya commented 6 years ago

Removed all the OpenShift and Kubernetes settings used for content repository in order to remove content repo
Also removed init container(wait for content repo) from Jenkins

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

kishansagathiya commented 6 years ago

I can't test these changes by updating the tenant, because what update tenant is similar to oc apply. They use something called three way merge, where they compare current config and asked config and based on that make changes.

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

kishansagathiya commented 6 years ago

from @rupalibehera

IMO we should also check how much time we require for subsequent builds after removing content-repository does that make any difference

kishansagathiya commented 6 years ago

@rupalibehera I don't see any change in build times

screenshot from 2018-08-02 15-34-58 screenshot from 2018-08-02 17-28-18

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

kishansagathiya commented 6 years ago

@hrishin have tested latest changes with a few builds

kishansagathiya commented 6 years ago

This is one such successfully built commit https://github.com/kishansagathiya/app-test-1/commit/2ed2570ce6d4a7172e2d5a96bf33092b36ab5dfd