Maven settings changed - Githubissues

fabric8-services / fabric8-tenant-jenkins

Generates Jenkins tenant namespace YAML

Apache License 2.0

2 stars 14 forks source link

Closed hrishin closed 6 years ago

hrishin commented 6 years ago

Changed maven local repository file location from /root/.mvnrepository to default

@rupalibehera @jaseemabid @sthaha @chmouel

jaseemabid commented 6 years ago

@hrishin My patch does the same, but I've been unable to start a build and test it.

jaseemabid commented 6 years ago

Ah! Now I know why grepping for this never worked. Damn!

I see another volume mounted at the same path.

volumes: [secretVolume(secretName: 'jenkins-maven-settings', mountPath: '/root/.m2'),

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

fabric8cd commented 6 years ago

PR now available for testing: Launch in OpenShift.io and click the update tenant button

jaseemabid commented 6 years ago

@hrishin Since we are changing permissions in the image, shall we close this PR?