Closed concaf closed 6 years ago
This should fix https://github.com/openshiftio/openshift.io/issues/3469
PR now available for testing: Launch in OpenShift.io and click the update tenant button
ping @jaseemabid @rupalibehera
Very clever. Do you know if the init container will timeout after some time? Let's say the content-repository deployment never comes up for some reason...
Something like this may be better so it eventually times
for i in {1..100}; do sleep 1; if curl... ; then exit 0; fi; done; exit 1
@jfchevrette makes sense, trying with for i in {1..100}; do sleep 1; if curl -L -m 4 content-repository; then exit 0; else echo waiting for content-repository ...; fi; done; exit 1
PR now available for testing: Launch in OpenShift.io and click the update tenant button
This works for me, would help if more folks can test this out to move forward with this -
Steps to test -
oc idle jenkins content-repository
curl -L jenkins-username-jenkins.xyz.openshiftapps.com
Patch looks good to me, works for me.
It worked for me. 3 trials : 3 success, 0 failed
@containscafeine I added my observations here https://github.com/openshiftio/openshift.io/issues/3469#issuecomment-387064855, I can merge this is PR, let me know if you don't have the merge rights.
LGTM
Looks good here too!
https://github.com/openshiftio/saas-openshiftio/pull/874 PR raised to deploy to prod
This commit adds a hard dependency on the Jenkins deployment such that Jenkins will not be brought up unless content-repository is not up and running.
This is done by adding init containers to the Jenkins' Kubernetes Deployment files which check every 2 seconds if content-repository is up or not. The check is set to timeout at 2 seconds. Once the check returns a 0 exit code and the init container exits, only then the Jenkins pod is brought up.