search

fabric8-services / fabric8-tenant

Service responsible for provisioning and updating the tenant scoped services
Apache License 2.0
12 stars 29 forks source link

fix(#749): don't use "delete all" endpoints and clean all object one by one #750

Closed MatousJobanek closed 5 years ago

MatousJobanek commented 5 years ago

when doing clean action, instead of calling "delete all" endpoints (eg. delete all PVC ) for all,pvc,cm kinds retrieve all available objects of that kind for every namespace and delete the objects one by one.

Fixes: #749

codecov[bot] commented 5 years ago

Codecov Report

Merging #750 into master will increase coverage by 1.29%. The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   75.46%   76.76%   +1.29%     
==========================================
  Files          37       37              
  Lines        3037     3210     +173     
==========================================
+ Hits         2292     2464     +172     
- Misses        557      559       +2     
+ Partials      188      187       -1
Impacted Files Coverage Δ
openshift/methods.go 97.72% <ø> (-0.26%) :arrow_down:
openshift/endpoints.go 92.85% <ø> (ø) :arrow_up:
openshift/callback.go 78.03% <100%> (ø) :arrow_up:
openshift/action.go 91.82% <95.12%> (+8.36%) :arrow_up:
toggles/toggles.go 23.8% <0%> (-6.81%) :arrow_down:
openshift/types.go 94.28% <0%> (+0.69%) :arrow_up:
environment/template.go 89.13% <0%> (+0.72%) :arrow_up:
controller/tenant.go 71.92% <0%> (+0.87%) :arrow_up:
openshift/service.go 83.47% <0%> (+1.11%) :arrow_up:
tenant/tenant.go 77.41% <0%> (+6.45%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f58fb3...4f8a2bd. Read the comment docs.