search

fabric8-services / fabric8-tenant

Service responsible for provisioning and updating the tenant scoped services
Apache License 2.0
12 stars 29 forks source link

fix: delete objects in correct order & use merge-patch type for updates #753

Closed MatousJobanek closed 5 years ago

MatousJobanek commented 5 years ago

When doing clean action, the DeploymentConfig should be removed before ReplicationController and this one before Pods.

MatousJobanek commented 5 years ago

[test]

codecov[bot] commented 5 years ago

Codecov Report

Merging #753 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   75.24%   75.25%   +<.01%     
==========================================
  Files          37       37              
  Lines        3082     3083       +1     
==========================================
+ Hits         2319     2320       +1     
  Misses        573      573              
  Partials      190      190
Impacted Files Coverage Δ
environment/template.go 88.4% <ø> (ø) :arrow_up:
openshift/methods.go 98% <100%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 820dddb...43f78b3. Read the comment docs.