search

fabric8-services / fabric8-tenant

Service responsible for provisioning and updating the tenant scoped services
Apache License 2.0
12 stars 29 forks source link

fix(CRT-355): username shouldn't be a number nor start nor end with dash #778

Closed MatousJobanek closed 4 years ago

MatousJobanek commented 4 years ago

the userName that is used for namespace provisioning shouldn't start nor end with dash and shouldn't be a number. If it doesn't comply with these conditions, then it gets either os prefix or io suffix or both. Also changed the failing User template so the problematic annotation is in a format of string (similarly as is done in Che template)

codecov[bot] commented 4 years ago

Codecov Report

Merging #778 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
+ Coverage   74.97%   75.03%   +0.06%     
==========================================
  Files          38       38              
  Lines        3177     3185       +8     
==========================================
+ Hits         2382     2390       +8     
  Misses        593      593              
  Partials      202      202
Impacted Files Coverage Δ
environment/template.go 89.04% <100%> (+0.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d215aa6...1d38f56. Read the comment docs.

almighty-bot commented 4 years ago

This PR changes one or more of the template files. These changes are now available for testing: Launch in OpenShift.io and click the update tenant button