Only space collaborator should be able to create a work item

fabric8-services / fabric8-wit

wit stands for Work Item Tracker

http://devdoc.almighty.io/

Apache License 2.0

45 stars 86 forks source link

Only space collaborator should be able to create a work item #1358

Closed alexeykazakov closed 7 years ago

alexeykazakov commented 7 years ago

Currently we allow any logged-in user to create a work item in any space.

@qodfathr wants to limit it to the space collaborators only.

sbose78 commented 7 years ago

Why are we doing this @qodfathr ? The github model of allowing anyone to go and file an issue was nice.

maxandersen commented 7 years ago

This have to be incorrect. I can see it as an option to enable for other projects but for our openshift.io spaces we are looking to let anyone logged into open issues. Otherwise we cannot use openshift.io for our issue tracking with the broader world.

qodfathr commented 7 years ago

It needs to be this way for now. We need some important controls in place before we can have a model for non-contributors to add items. The GitHub model does not have to deal with things like Epics, Scenarios, bugs vs features, etc. Plus there is the whole issue of managing rank, priorities, approving items, etc.

maxandersen commented 7 years ago

lets then block non-collaborators from managing ranks etc. which is already what is there imo.

qodfathr commented 7 years ago

It's more complex that that, and this has already been discussed and decided. I'll say it again: it's a short term change until we've identified all the use cases and consequences.

-Todd

Sent from my phone so please excuse humorous autocorrects

From: Max Rydahl Andersen notifications@github.com Sent: Thursday, June 1, 2017 6:48:53 AM To: almighty/almighty-core Cc: Todd Mancini; Mention Subject: Re: [almighty/almighty-core] Only space collaborator should be able to create a work item (#1358)

lets then block non-collaborators from managing ranks etc. which is already what is there imo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/almighty/almighty-core/issues/1358#issuecomment-305458541, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APkOjkO670U2GdoGxTxqc2VR3ggaZFtVks5r_pcVgaJpZM4NsczC.

cctrieloff commented 7 years ago

What if we allow just issues to be created by non collaborators for now?

alexeykazakov commented 7 years ago

https://github.com/almighty/almighty-core/pull/1359 closes work item creation for non-collaborators in regular user spaces but allows non-collaborators to create work items in the spaces which belong to "openshiftio" user. This is a temporal workaround until we get some permission model designed and implemented. @qodfathr does it work for you?