Preeticp commented 6 years ago

The infotip for Work Items was updated in the glossary and JSON as per the old method. This PR adds the infotip to the Agile template as per the new method.

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @Preeticp for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

Preeticp commented 6 years ago

@michaelkleinhenz I have changed the case to small for 'description'

codecov-io commented 6 years ago

Codecov Report

Merging #2266 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2266   +/-   ##
=======================================
  Coverage   70.23%   70.23%           
=======================================
  Files         171      171           
  Lines       16625    16625           
=======================================
  Hits        11676    11676           
  Misses       3822     3822           
  Partials     1127     1127

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5205666...4fce8b4. Read the comment docs.

jarifibrahim commented 6 years ago

[test]

kwk commented 6 years ago

[test]

jarifibrahim commented 6 years ago

Build failed with

--- FAIL: TestIdentityRepository (0.13s)

panic: (*logrus.Entry) (0xbc99a0,0xc4205580f0) [recovered]

    panic: (*logrus.Entry) (0xbc99a0,0xc4205580f0)

goroutine 19 [running]:

testing.tRunner.func1(0xc4201483c0)

    /usr/lib/golang/src/testing/testing.go:711 +0x2d2

panic(0xbc99a0, 0xc4205580f0)

    /usr/lib/golang/src/runtime/panic.go:491 +0x283

github.com/fabric8-services/fabric8-wit/vendor/github.com/sirupsen/logrus.Entry.log(0xc420070500, 0xc42006bf50, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)

    /tmp/go/src/github.com/fabric8-services/fabric8-wit/vendor/github.com/sirupsen/logrus/entry.go:124 +0x5eb

github.com/fabric8-services/fabric8-wit/vendor/github.com/sirupsen/logrus.(*Entry).Panic(0xc4205580a0, 0xc4205b9b70, 0x1, 0x1)

    /tmp/go/src/github.com/fabric8-services/fabric8-wit/vendor/github.com/sirupsen/logrus/entry.go:169 +0xa8

github.com/fabric8-services/fabric8-wit/vendor/github.com/sirupsen/logrus.(*Entry).Panicln(0xc4205580a0, 0xc4205b9bf8, 0x1, 0x1)

    /tmp/go/src/github.com/fabric8-services/fabric8-wit/vendor/github.com/sirupsen/logrus/entry.go:264 +0xe0

github.com/fabric8-services/fabric8-wit/log.Panic(0x0, 0x0, 0xc42006be00, 0xc06e92, 0x31, 0x0, 0x0, 0x0)

    /tmp/go/src/github.com/fabric8-services/fabric8-wit/log/log.go:218 +0x23c

github.com/fabric8-services/fabric8-wit/gormtestsupport.(*DBTestSuite).populateDBTestSuite(0xc4204994a0, 0x1016a00, 0xc4205ae390)

    /tmp/go/src/github.com/fabric8-services/fabric8-wit/gormtestsupport/db_test_suite.go:83 +0x265

github.com/fabric8-services/fabric8-wit/gormtestsupport.(*DBTestSuite).SetupSuite(0xc4204994a0)

    /tmp/go/src/github.com/fabric8-services/fabric8-wit/gormtestsupport/db_test_suite.go:61 +0x158

github.com/fabric8-services/fabric8-wit/vendor/github.com/stretchr/testify/suite.Run(0xc4201483c0, 0x1012200, 0xc4204994a0)

    /tmp/go/src/github.com/fabric8-services/fabric8-wit/vendor/github.com/stretchr/testify/suite/suite.go:64 +0x63b

github.com/fabric8-services/fabric8-wit/account_test.TestIdentityRepository(0xc4201483c0)

    /tmp/go/src/github.com/fabric8-services/fabric8-wit/account/identity_blackbox_test.go:23 +0xd2

testing.tRunner(0xc4201483c0, 0xc58960)

    /usr/lib/golang/src/testing/testing.go:746 +0xd0

created by testing.(*T).Run

    /usr/lib/golang/src/testing/testing.go:789 +0x2de

FAIL    github.com/fabric8-services/fabric8-wit/account 0.185s

@kwk I saw a couple of PRs failing with the same error. We should fix this issue. We have some kind of race condition.

jarifibrahim commented 6 years ago

[test]

kwk commented 6 years ago

@kwk I saw a couple of PRs failing with the same error. We should fix this issue. We have some kind of race condition.

not seen this error so far

Preeticp commented 5 years ago

@kwk, @jarifibrahim can you please merge this PR, we could close this issue by doing so: https://github.com/openshiftio/openshift.io/issues/4403#issuecomment-438535140

jarifibrahim commented 5 years ago

/ok-without-tests

fabric8-services / fabric8-wit

Adds infotips for Work Items WIG #2266

Ike Plugins (test-keeper)

Codecov Report