fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Better error logging for Delete action on /space endpoint #2280

Closed jarifibrahim closed 6 years ago

jarifibrahim commented 6 years ago

The DELETE action on /space endpoint often fails with could not delete space Example failure - https://errortracking.prod-preview.openshift.io/openshift_io/fabric8-wit/issues/2083 Error logs from Kibana shows

"error": "could not decode JSON formatted errors returned while deleting codebase ac20e514-d72a-46a2-bfc7-23ed58d762e9: invalid character '<' looking for beginning of value\n"

which doesn't show any information apart from the error.

This PR improves the error logging so that we can see what the actual response was from the codebase API when delete fails.

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @jarifibrahim for this contribution!

It seems that this PR already contains some added or changed tests. Good job!

For more information please head over to official documentation. You can find there how to configure the plugin.

codecov-io commented 6 years ago

Codecov Report

Merging #2280 into master will decrease coverage by 0.08%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2280      +/-   ##
==========================================
- Coverage   69.52%   69.43%   -0.09%     
==========================================
  Files         176      176              
  Lines       16670    16679       +9     
==========================================
- Hits        11589    11581       -8     
- Misses       3957     3974      +17     
  Partials     1124     1124
Impacted Files Coverage Δ
controller/space.go 68.55% <0%> (-1.28%) :arrow_down:
remoteworkitem/jira.go 75% <0%> (-25%) :arrow_down:
remoteworkitem/scheduler.go 53.65% <0%> (-7.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8fab53...be82193. Read the comment docs.

jarifibrahim commented 6 years ago

[test]

jarifibrahim commented 6 years ago

[test]

jarifibrahim commented 6 years ago

[test]