Closed kwk closed 5 years ago
Thank you @kwk for this contribution!
It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests
as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.
Merging #2312 into master will increase coverage by
0.07%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #2312 +/- ##
==========================================
+ Coverage 70.04% 70.12% +0.07%
==========================================
Files 174 174
Lines 16796 16796
==========================================
+ Hits 11765 11778 +13
+ Misses 3897 3887 -10
+ Partials 1134 1131 -3
Impacted Files | Coverage Δ | |
---|---|---|
workitem/workitem_repository.go | 68.02% <0%> (+0.22%) |
:arrow_up: |
controller/workitem.go | 78.83% <0%> (+0.56%) |
:arrow_up: |
remoteworkitem/scheduler.go | 60.97% <0%> (+7.31%) |
:arrow_up: |
remoteworkitem/jira.go | 100% <0%> (+25%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a661437...040cd97. Read the comment docs.
/ok-without-tests
Based on this discussion we first remove the unique name index on the
iterations
andareas
table before we modify the data.This should fix the migration issue that was visible here: https://github.com/openshiftio/saas-openshiftio/pull/1082