search

fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Use closeable package from fabric8-common #2320

Closed baijum closed 4 years ago

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @baijum for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

baijum commented 5 years ago

[test]

baijum commented 5 years ago

[test]

baijum commented 5 years ago

[test]

baijum commented 5 years ago

[test]

baijum commented 5 years ago

[test]

kwk commented 5 years ago

@baijum I saw that the current Gopkg.lock contains this section:

[[projects]]
  name = "github.com/fabric8-services/fabric8-common"
  packages = ["id"]
  revision = "51e44b47e514721ddaa3fca99e5fb5bc1a6e7eb2"

Don't we have to add the closable package here as well?