fabric8-services / fabric8-wit

wit stands for Work Item Tracker

http://devdoc.almighty.io/

Apache License 2.0

45 stars 86 forks source link

Use default failureThreshold value #2328

Open jarifibrahim opened 5 years ago

jarifibrahim commented 5 years ago

The fabric8-wit deployment to prod-preview was successful with https://github.com/fabric8-services/fabric8-wit/pull/2327. We don't need failureThreshold:120 which is

Minimum consecutive failures for the probe to be considered failed after having succeeded

from https://docs.openshift.com/container-platform/3.5/rest_api/openshift_v1.html#v1-probe

This PR changes the failureThreshold value back to its default value which was changed in https://github.com/fabric8-services/fabric8-wit/pull/2298 and https://github.com/fabric8-services/fabric8-wit/pull/2295

Also see https://github.com/fabric8-services/fabric8-wit/issues/2291

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @jarifibrahim for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

codecov[bot] commented 5 years ago

Codecov Report

Merging #2328 into master will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2328      +/-   ##
==========================================
- Coverage   70.17%   70.15%   -0.02%     
==========================================
  Files         171      171              
  Lines       16625    16625              
==========================================
- Hits        11666    11664       -2     
- Misses       3829     3830       +1     
- Partials     1130     1131       +1

Impacted Files	Coverage Δ
workitem/workitem_repository.go	`67.79% <0%> (-0.23%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbd8f88...314f456. Read the comment docs.