search

fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Golden file fixes for field rename #2331

Closed jarifibrahim closed 5 years ago

jarifibrahim commented 5 years ago

This PR builds upon https://github.com/fabric8-services/fabric8-wit/pull/2330. I will update this PR once https://github.com/fabric8-services/fabric8-wit/pull/2330 is merged.

This PR updates all the golden files.

The full text search depends on the TSV which are not yet fixed and the IfModifiedSince tests depend on the triggers defined on work_item table. We have not yet fixed a database and it's causing test failures. These tests have been temporarily skipped by https://github.com/fabric8-services/fabric8-wit/pull/2331/commits/b5b025165b954a31513e8c018c301ff5ea459295. I have created an issue for this https://github.com/fabric8-services/fabric8-wit/issues/2332.

codecov[bot] commented 5 years ago

Codecov Report

Merging #2331 into osio-story-743-rename-fields will decrease coverage by 0.1%. The diff coverage is 91.66%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           osio-story-743-rename-fields    #2331      +/-   ##
================================================================
- Coverage                         70.18%   70.08%   -0.11%     
================================================================
  Files                               171      171              
  Lines                             16625    16625              
================================================================
- Hits                              11669    11652      -17     
- Misses                             3828     3841      +13     
- Partials                           1128     1132       +4
Impacted Files Coverage Δ
workitem/workitem.go 57.64% <ø> (ø) :arrow_up:
workitem/workitemtype.go 73.62% <ø> (ø) :arrow_up:
remoteworkitem/remoteworkitem.go 78.87% <ø> (ø) :arrow_up:
workitem/table_join.go 89.89% <ø> (ø) :arrow_up:
controller/planner_backlog.go 64.13% <0%> (ø) :arrow_up:
workitem/workitem_repository.go 67.79% <100%> (-0.23%) :arrow_down:
codebase/codebase.go 73% <100%> (ø) :arrow_up:
workitem/expression_compiler.go 81.17% <100%> (ø) :arrow_up:
controller/workitem.go 81.18% <100%> (-0.56%) :arrow_down:
controller/workitems.go 77.43% <100%> (ø) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44739f8...740b5da. Read the comment docs.

jarifibrahim commented 5 years ago

Closing this in favour of https://github.com/fabric8-services/fabric8-wit/pull/2333. https://github.com/fabric8-services/fabric8-wit/pull/2333 contains all the golden files with final updates.

This PR had golden files changed from system.title to system_title. https://github.com/fabric8-services/fabric8-wit/pull/2333 has golden files changed from system.title to system.title and system_title that is, both the field names are present. Since we need the later, I'm closing this PR.