Closed jarifibrahim closed 5 years ago
:exclamation: No coverage uploaded for pull request base (
osio-story-743-rename-fields@5300ce5
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## osio-story-743-rename-fields #2333 +/- ##
===============================================================
Coverage ? 70.12%
===============================================================
Files ? 171
Lines ? 16641
Branches ? 0
===============================================================
Hits ? 11670
Misses ? 3840
Partials ? 1131
Impacted Files | Coverage Δ | |
---|---|---|
workitem/workitemtype.go | 73.62% <ø> (ø) |
|
controller/workitem.go | 81.72% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5300ce5...31d7ccf. Read the comment docs.
[test]
:exclamation: No coverage uploaded for pull request base (
osio-story-743-rename-fields@b942caf
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## osio-story-743-rename-fields #2333 +/- ##
===============================================================
Coverage ? 70.18%
===============================================================
Files ? 171
Lines ? 16641
Branches ? 0
===============================================================
Hits ? 11680
Misses ? 3833
Partials ? 1128
Impacted Files | Coverage Δ | |
---|---|---|
workitem/workitemtype.go | 73.62% <ø> (ø) |
|
controller/workitem.go | 81.72% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b942caf...fc9ed88. Read the comment docs.
~This PR builds upon https://github.com/fabric8-services/fabric8-wit/pull/2330. I will update this PR once https://github.com/fabric8-services/fabric8-wit/pull/2330 is merged.~
~Blocked by https://github.com/fabric8-services/fabric8-wit/pull/2345~
See https://github.com/fabric8-services/fabric8-wit/issues/2343
The PR -
Fixes tests in expression_compiler https://github.com/fabric8-services/fabric8-wit/pull/2333/commits/d0e6171f032a508c6dfe71a5fd1628c43722e34f
IfModifiedSince
tests depend on the triggers defined onwork_item
table. We have not yet fixed a database and it's causing test failures. I have created an issue for this https://github.com/fabric8-services/fabric8-wit/issues/2332.Adds
replaceFieldName
(incoming/request workitem payload) andaddFieldName
(outgoing/response payload) with tests https://github.com/fabric8-services/fabric8-wit/pull/2333/commits/99154fc602ccc49d45b6d15f293424f816535a4f The request and response payload for /workitem(s) endpoint has changedTodo
/workitemtype
endpoint response payload https://github.com/fabric8-services/fabric8-wit/pull/2335/workitem/events
endpoint response to return appropriate response (We can't send all the events twice) https://github.com/fabric8-services/fabric8-wit/pull/2337