fabric8-services / fabric8-wit

wit stands for Work Item Tracker

http://devdoc.almighty.io/

Apache License 2.0

45 stars 86 forks source link

Rename SystemBoardColumns to BoardColumns in workitem relationships #2345

Closed jarifibrahim closed 5 years ago

jarifibrahim commented 5 years ago

See https://github.com/fabric8-services/fabric8-wit/pull/2333#discussion_r230684240

codecov[bot] commented 5 years ago

Codecov Report

Merging #2345 into master will not change coverage. The diff coverage is 75%.

@@           Coverage Diff           @@
##           master    #2345   +/-   ##
=======================================
  Coverage   70.17%   70.17%           
=======================================
  Files         171      171           
  Lines       16625    16625           
=======================================
  Hits        11666    11666           
  Misses       3829     3829           
  Partials     1130     1130

Impacted Files	Coverage Δ
controller/workitem.go	`81.18% <75%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9dc1c08...85ca761. Read the comment docs.

jarifibrahim commented 5 years ago

LGTM but it will break the UI. The comment from the description is not saying that we can replace this board columns relationship with a different name. We can add another relation called boardcolumns though. It would be the same as with the system.title field that shows up as system_title as well.

@kwk UI doesn't use board columns. We have empty boards. Renaming this relationship should not have any effect on the UI.

jarifibrahim commented 5 years ago

I ran this PR against UI and nothing broke.

jarifibrahim commented 5 years ago

I've raised https://github.com/fabric8-ui/fabric8-planner/pull/2803 to update the UI.

kwk commented 5 years ago

LGTM but it will break the UI. The comment from the description is not saying that we can replace this board columns relationship with a different name. We can add another relation called boardcolumns though. It would be the same as with the system.title field that shows up as system_title as well.

@kwk UI doesn't use board columns. We have empty boards. Renaming this relationship should not have any effect on the UI.

I thought we have demoed that some time ago.