fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Trackerquery refactor #2351

Closed DhritiShikhar closed 5 years ago

DhritiShikhar commented 5 years ago

[1] refactors trackerquery code [2] add migration file to move trackerquery id from string to uuid [3] changes the trackerquery payload to include tracker and space in relationships [4] checks for logged in user for write actions

codecov[bot] commented 5 years ago

Codecov Report

Merging #2351 into master will decrease coverage by 0.3%. The diff coverage is 56.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2351      +/-   ##
==========================================
- Coverage   70.18%   69.87%   -0.31%     
==========================================
  Files         171      171              
  Lines       16919    16928       +9     
==========================================
- Hits        11874    11829      -45     
- Misses       3893     3938      +45     
- Partials     1152     1161       +9
Impacted Files Coverage Δ
remoteworkitem/trackerquery.go 100% <ø> (ø) :arrow_up:
remoteworkitem/tracker_repository.go 64.28% <ø> (ø) :arrow_up:
remoteworkitem/github.go 100% <100%> (+22.85%) :arrow_up:
migration/migration.go 69.28% <100%> (+0.11%) :arrow_up:
remoteworkitem/trackerquery_repository.go 58.97% <53.84%> (-24.72%) :arrow_down:
controller/trackerquery.go 56.32% <56%> (+2.3%) :arrow_up:
remoteworkitem/errors.go 0% <0%> (-33.34%) :arrow_down:
remoteworkitem/jira.go 75% <0%> (-25%) :arrow_down:
controller/tracker.go 56.92% <0%> (-13.85%) :arrow_down:
jsonapi/error_handler.go 45.71% <0%> (+2.85%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7fb836...740d264. Read the comment docs.

DhritiShikhar commented 5 years ago

@kwk changed the position of error here 512136e