fabric8-services / fabric8-wit

wit stands for Work Item Tracker

http://devdoc.almighty.io/

Apache License 2.0

45 stars 86 forks source link

add .golangci.yml #2355

Closed jirfag closed 5 years ago

jirfag commented 5 years ago

As was suggested in https://github.com/golangci/golangci/issues/18, we've supported custom build commands in .golangci.yml. Now this repo can be successfully analyzed by https://golangci.com

centos-ci commented 5 years ago

Can one of the admins verify this patch?

centos-ci commented 5 years ago

Can one of the admins verify this patch?

centos-ci commented 5 years ago

Can one of the admins verify this patch?

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @jirfag for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

alexeykazakov commented 5 years ago

/ok-without-tests

alexeykazakov commented 5 years ago

[test]

codecov[bot] commented 5 years ago

Codecov Report

Merging #2355 into master will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2355      +/-   ##
==========================================
- Coverage   69.89%   69.87%   -0.02%     
==========================================
  Files         171      171              
  Lines       16928    16928              
==========================================
- Hits        11831    11829       -2     
- Misses       3937     3938       +1     
- Partials     1160     1161       +1

Impacted Files	Coverage Δ
workitem/workitem_repository.go	`67.79% <0%> (-0.23%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0437a5...37d82cf. Read the comment docs.

jirfag commented 5 years ago

sure, added it

kwk commented 5 years ago

sure, added it

@jirfag thank you for adding that link. IMHO it is not a good idea to keep configuration information on a wiki page because that might diverge from your code and it doesn't evolve with your code. If you introduce a new concept in your config and that isn't available in an older version of golangci you're out of sync. I would suggest to store the config wiki page in a markdown file inside of the real repo.

jirfag commented 5 years ago

The page contains description of service configuration and link to linter configuration. Service configuration can’t be downgraded or not supported: we change it only after real changes. Linter configuration is already in the readme of golangci-lint to be in sync.

jirfag commented 5 years ago

is it ok to merge?

kwk commented 5 years ago

[test]

jirfag commented 5 years ago

How can I help you to get it merged?

alexeykazakov commented 5 years ago

[test]

kwk commented 5 years ago

How can I help you to get it merged?

@jirfag its fine. @alexeykazakov and I were just bringing this PR to the newest state so it can go on top of master. The test comment by me kicks off a new test run in our CI if something broke before. Once the tests pass, we can have it merged. Thanks for your patience.

alexeykazakov commented 5 years ago

[test]

jirfag commented 5 years ago

thank you!

alexeykazakov commented 5 years ago

thank you @jirfag for the contribution! :)