Closed corinnekrych closed 5 years ago
Merging #2358 into master will decrease coverage by
0.02%
. The diff coverage is63.29%
.
@@ Coverage Diff @@
## master #2358 +/- ##
==========================================
- Coverage 69.87% 69.85% -0.03%
==========================================
Files 171 171
Lines 16976 17054 +78
==========================================
+ Hits 11862 11913 +51
- Misses 3950 3971 +21
- Partials 1164 1170 +6
Impacted Files | Coverage Δ | |
---|---|---|
account/identity.go | 57.38% <ø> (+1.7%) |
:arrow_up: |
controller/users.go | 73.98% <63.29%> (-5.19%) |
:arrow_down: |
controller/workitem.go | 78.82% <0%> (-0.43%) |
:arrow_down: |
account/user.go | 53.08% <0%> (+2.46%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 58492e8...28cf52b. Read the comment docs.
@sbose78 @jarifibrahim I've moved all logic in controller in 268a4fa3f0b1c93b6d33a76f07b0d3b9933425a6 but tbh I don't like it, I found the controller more readable with less logic and the obfuscate
method at DAO level makes sense to me (close to soft delete).
I've also rebased so let see how the CI checks turn out and if we can merge it.
[test]
[test]
@jarifibrahim @sbose78 @tinakurian Good to merge?
[test]
[test]
[test]
Please describe what your change is about. This PR provide a WIT API to obfuscate user and identity information.
What issues does it solve? (Use autoreferencing for this) OSIO 804 Background: https://gitlab.cee.redhat.com/dtsd/housekeeping/issues/2108