search

fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Rename Iteration resolved_parent_path to parent_path_resolved #2373

Closed sahil143 closed 4 years ago

sahil143 commented 5 years ago

Taken From https://github.com/openshiftio/openshift.io/issues/4589

Issue Overview

Response for https://prod-preview.openshift.io/api/spaces/${SPACE_ID}/iterations

{
 data: [
       { 
         attributes: {
            parent_path: "/",
            resolved_parent_path: "/ "
            ...
         }
         ...
       }
       ...
]}

Response for https://prod-preview.openshift.io/api/spaces/${SPACE_ID}/areas

{
 data: [
       { 
         attributes: {
            parent_path: "/",
            parent_path_resolved: "/ "
            ...
         }
         ...
       }
       ...
]}

Either the name should be resolved_parent_path or parent_path_resolved?

This PR deprecates resolved_parent_path field and adds a new field parent_path_resolved. resolved_parent_path will be removed once the client migrates to the new field. Issue to track removal of de[recated field: #2374

codecov[bot] commented 5 years ago

Codecov Report

Merging #2373 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2373      +/-   ##
==========================================
+ Coverage   67.82%   67.82%   +<.01%     
==========================================
  Files         183      183              
  Lines       17994    17995       +1     
==========================================
+ Hits        12204    12206       +2     
  Misses       4616     4616              
+ Partials     1174     1173       -1
Impacted Files Coverage Δ
controller/iteration.go 78.44% <100%> (+0.05%) :arrow_up:
workitem/workitem_repository.go 67.79% <0%> (-0.23%) :arrow_down:
controller/workitem.go 78.59% <0%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c71948...75320fa. Read the comment docs.