search

fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Use Proxy from common #2377

Open alexeykazakov opened 5 years ago

alexeykazakov commented 5 years ago

Address issue in our proxy which we found after upgrading go to 1.11. See https://github.com/fabric8-services/fabric8-auth/issues/734

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @alexeykazakov for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@6c2caea). Click here to learn what that means. The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2377   +/-   ##
=========================================
  Coverage          ?   69.89%           
=========================================
  Files             ?      170           
  Lines             ?    16961           
  Branches          ?        0           
=========================================
  Hits              ?    11855           
  Misses            ?     3948           
  Partials          ?     1158
Impacted Files Coverage Δ
controller/collaborators.go 0% <0%> (ø)
controller/users.go 73.98% <0%> (ø)
controller/search.go 70.24% <0%> (ø)
controller/login.go 41.66% <0%> (ø)
controller/features.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c2caea...a0e0635. Read the comment docs.

alexeykazakov commented 5 years ago

This PR is ready for review. It's WIP until we finish additional testing to make sure the issue is fixed by this PR.

sbose78 commented 5 years ago

To be merged after upgrading to go1.11 https://github.com/fabric8-services/fabric8-wit/pull/2378