search

fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Use golang 1.9.4 from website #2383

Closed jarifibrahim closed 5 years ago

jarifibrahim commented 5 years ago

See https://github.com/openshiftio/openshift.io/issues/4631#issuecomment-448164687

We know the /deployments/spaces API fails on prod-preview with go1.10. This PR builds fabric8-wit with go1.9.4. We will be upgrading the golang version in a separate PR but this PR will be used as a fallback when go1.10/go1.11 fail.

jarifibrahim commented 5 years ago

The coverage build is taking too long because go1.9.4 doesn't support test cache. We'll have to merge https://github.com/fabric8-services/fabric8-wit/pull/2378 so that we can use golang from epel.

We'll use

  1. go1.9.4 from website to run tests without coverage and build the binary
  2. go1.11 from epel to run tests with coverage
codecov[bot] commented 5 years ago

Codecov Report

Merging #2383 into master will increase coverage by 0.2%. The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2383     +/-   ##
=========================================
+ Coverage    69.9%   70.11%   +0.2%     
=========================================
  Files         171      174      +3     
  Lines       16992    17121    +129     
=========================================
+ Hits        11879    12005    +126     
+ Misses       3953     3951      -2     
- Partials     1160     1165      +5
Impacted Files Coverage Δ
auth/authz.go 0% <0%> (ø) :arrow_up:
controller/deployments.go 55.84% <0%> (ø) :arrow_up:
login/service.go 10.66% <0%> (ø) :arrow_up:
controller/work_item_link.go 81.74% <100%> (ø) :arrow_up:
gormapplication/application.go 70.66% <0%> (ø)
gormsupport/cleaner/db_clean.go 100% <0%> (ø)
resource/require.go 78.26% <0%> (ø)
migration/migration.go 77.85% <0%> (+8.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe049a7...c846788. Read the comment docs.