Closed corinnekrych closed 5 years ago
Let's have this service called by the Auth service, since the Auth service is the source of truth for any user information.
@sbose78 ok, I've rolled back to use auth-service instead of admin-console. Good to go?
Merging #2386 into master will decrease coverage by
0.06%
. The diff coverage is55.46%
.
@@ Coverage Diff @@
## master #2386 +/- ##
==========================================
- Coverage 67.82% 67.75% -0.07%
==========================================
Files 183 183
Lines 17994 18122 +128
==========================================
+ Hits 12204 12279 +75
- Misses 4616 4661 +45
- Partials 1174 1182 +8
Impacted Files | Coverage Δ | |
---|---|---|
migration/migration.go | 78.01% <100%> (+0.07%) |
:arrow_up: |
account/user.go | 50% <43.9%> (-3.09%) |
:arrow_down: |
controller/users.go | 70% <54.68%> (-3.99%) |
:arrow_down: |
space/space.go | 70.25% <77.27%> (+0.6%) |
:arrow_up: |
workitem/workitem_revision_repository.go | 86.2% <0%> (-6.9%) |
:arrow_down: |
workitem/workitem_repository.go | 68.7% <0%> (+0.67%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8c71948...7d644ab. Read the comment docs.
@sbose78 @kwk with d2c983d addresses the issue for:
[test]
[test]
[test]